[PATCH] D136829: [SDAG] Fix v1i8 -> 1x i32 handling in getCopyToPartsVector

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 07:20:20 PDT 2022


Pierre-vh added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/dagcombine-v1i8-extractvecelt-crash.ll:41
+  %load = load <1 x i8>, <1 x i8> addrspace(5)* %addr, align 1
+  store <1 x i8> poison, <1 x i8> addrspace(5)* %addr, align 1
+  store <1 x i8> %load, <1 x i8> addrspace(5)* %addr, align 1
----------------
arsenm wrote:
> Is this store of poison really doing anything here?
Both the stores & the loop are needed somehow, removing either makes the bug disappear - I think it simplifies everything away in those cases


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136829/new/

https://reviews.llvm.org/D136829



More information about the llvm-commits mailing list