[PATCH] D136678: [AArch64][SVE2] Add the SVE2.1 pext and ptrue predicate-as-counter instructions

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 01:22:45 PDT 2022


david-arm marked 2 inline comments as done.
david-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:883
+def PPR_3b : PPRClass<0, 7>; // Restricted 3 bit SVE predicate register class.
+def PPR_3b_p8_p15 : PPRClass<8, 15>;
 
----------------
sdesmalen wrote:
> paulwalker-arm wrote:
> > Given you specify the range does the `_3b` part provide any value? I'd rather just `PPR_p8_p15` or even `PPR_p8to15`.
> It would be nice to also rename `PPR_3b` to `PPR_p0to7` in that case (although preferably not as part of this patch)
Yep, I can do that in a follow-up!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136678/new/

https://reviews.llvm.org/D136678



More information about the llvm-commits mailing list