[PATCH] D136621: [polly] Remove legacy pass manager hooks

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a subscriber: grosser.
Meinersbur added a comment.

Some other Polly options become inaccessible using any pipeline builder: PollyACC (`-polly-target`), static expansion (`-polly-enable-mse`), polyhedral info (`-polly-enable-polyhedralinfo`), and JSON export (`-polly-export`).

`-polly-target`, `-polly-enable-mse` and `-polly-enable-polyhedralinfo` are experiments that are effectively unmaintained now and I think should also be removed in this patch (that is, the `cl::opt` options, I can remove the passes separately at some point unless someone jumps in to update them to the NPM)

I will commit a patch that makes `-polly-export` usable with the NPM.



================
Comment at: polly/lib/Support/RegisterPasses.cpp:629
+/// We can currently run Polly at three different points int the pass manager.
+/// a) very early, b) after the canonicalizing loop transformations and c) right
+/// before the vectorizer.
----------------
aeubanks wrote:
> Meinersbur wrote:
> > `b)` (`POSITION_AFTER_LOOPOPT` is not supported by the NPM because there is no extension point). Maybe remove it entirely?
> done.
> 
> that extension point looks like it was specifically for loop passes, but due to the legacy PM design it's possible to add non-loop passes and have it still run like that. so perhaps not worth porting to the new PM
>  it's possible to add non-loop passes and have it still run like that

do you mean //impossible//? I can only add loop passes at that point while Polly uses function passes.

That extension point was added to the legacy pass manager by @grosser explicitly to implement `-polly-position=after-loopopt`. I am not aware of any other use of it. 

In any case, I never used that position and therefore fine with removing it.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136621/new/

https://reviews.llvm.org/D136621