[PATCH] D136621: [polly] Remove legacy pass manager hooks

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 11:25:43 PDT 2022


aeubanks added a comment.

In D136621#3885759 <https://reviews.llvm.org/D136621#3885759>, @Meinersbur wrote:

> `-enable-new-pm` is going to be removed from `opt`? What is that patch doing that?

it's explicitly for the legacy PM -> new PM migration, which has basically already happened. on discourse <https://discourse.llvm.org/t/deprecation-of-enable-new-pm-option/65168> we've talked about how to deal with the option, and we're now trying to remove it



================
Comment at: polly/lib/Support/RegisterPasses.cpp:629
+/// We can currently run Polly at three different points int the pass manager.
+/// a) very early, b) after the canonicalizing loop transformations and c) right
+/// before the vectorizer.
----------------
Meinersbur wrote:
> `b)` (`POSITION_AFTER_LOOPOPT` is not supported by the NPM because there is no extension point). Maybe remove it entirely?
done.

that extension point looks like it was specifically for loop passes, but due to the legacy PM design it's possible to add non-loop passes and have it still run like that. so perhaps not worth porting to the new PM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136621/new/

https://reviews.llvm.org/D136621



More information about the llvm-commits mailing list