[PATCH] D136698: [SampleFDO] Persist profile staleness metrics into binary

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 11:35:58 PDT 2022


hoy added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:2174
+    MDBuilder MDB(Ctx);
+    SmallVector<std::pair<std::string, uint64_t>> ProfStatsVec;
+    if (FunctionSamples::ProfileIsProbeBased) {
----------------
nit: StringRef should work here since all keys are literal constants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136698/new/

https://reviews.llvm.org/D136698



More information about the llvm-commits mailing list