[PATCH] D136698: [SampleFDO] Persist profile staleness metrics into binary

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:370
+  if (NamedMDNode *LLVMStats = M.getNamedMetadata("llvm.stats")) {
+    auto *S = C.getObjectFileInfo()->getLLVMStatsSection();
+    Streamer.switchSection(S);
----------------
S could end up null. Suggest `getLLVMStatsSection` to return a non-null ptr even if it's non-elf. The work should work for non-elf since we are not using comdat concept here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136698/new/

https://reviews.llvm.org/D136698