[PATCH] D135929: [profile] Add binary ids into indexed profiles

Daniel Thornburgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 10:51:12 PDT 2022


mysterymath added a comment.

LGTM from my POV (general build IDisms, usability for debuginfod).



================
Comment at: llvm/lib/ProfileData/InstrProfWriter.cpp:285-286
+void InstrProfWriter::addBinaryIds(ArrayRef<llvm::object::BuildIDRef> BIs) {
+  for (unsigned I = 0; I < BIs.size(); ++I)
+    BinaryIds.push_back(BIs[I]);
+}
----------------
llvm::append_range(BinaryIds, BIs);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135929/new/

https://reviews.llvm.org/D135929



More information about the llvm-commits mailing list