[PATCH] D135929: [profile] Add binary ids into indexed profiles

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem marked 6 inline comments as done.
gulfem added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/InstrProf.h:1053
   Version8 = 8,
-  // The current version is 8.
+  // Binary ids are added.
+  Version9 = 9,
----------------
mysterymath wrote:
> nit: IDs
I consistently use `Id` instead of an `ID` throughout the implementation.


================
Comment at: llvm/lib/ProfileData/InstrProfWriter.cpp:284
 
+void InstrProfWriter::addBinaryIds(std::vector<llvm::object::BuildIDRef> BIs) {
+  for (auto BI : BIs) {
----------------
mysterymath wrote:
> ArrayRef<llvm:object::BuildIDRef>; that way, any vector-like collection can be used here. Also saves a copy.
 I overlooked this, and thanks for pointing that out. It should at least be a reference. I changed that to `ArrayRef` to make it more flexible. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135929/new/

https://reviews.llvm.org/D135929