[PATCH] D136676: [AMDGPU] Speedup SIFormMemoryClauses live-in register set calculation

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 11:53:22 PDT 2022


vpykhtin added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:280
 
-  for (MachineBasicBlock &MBB : MF) {
-    GCNDownwardRPTracker RPT(*LIS);
+  SmallVector<MachineInstr *, 16> FirstBBClauseMI;
+  for (auto &MBB : MF) {
----------------
arsenm wrote:
> You seem to be assuming a single clause per block. I'd expect to handle this a full clause in a time, within a single block.
Not quite, I just compute the live-in set for the first clause per BB to reset the RPTracker, then it is advanced to the next clause.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136676/new/

https://reviews.llvm.org/D136676



More information about the llvm-commits mailing list