[PATCH] D136676: [AMDGPU] Speedup SIFormMemoryClauses live-in register set calculation
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 25 11:46:28 PDT 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:280
- for (MachineBasicBlock &MBB : MF) {
- GCNDownwardRPTracker RPT(*LIS);
+ SmallVector<MachineInstr *, 16> FirstBBClauseMI;
+ for (auto &MBB : MF) {
----------------
You seem to be assuming a single clause per block. I'd expect to handle this a full clause in a time, within a single block.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136676/new/
https://reviews.llvm.org/D136676
More information about the llvm-commits
mailing list