[PATCH] D136629: [AMDGPU] Fix delay alu for VOPD with src2acc

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash updated this revision to Diff 470508.
Joe_Nash marked 6 inline comments as done.
Joe_Nash added a comment.

use const auto &, hoist loop invariant code, shorten td line length, delete parameter name underscores

Thanks for the comments. I will plan to land this after rebasing and testing, and leave aside the remaining refactoring opportunities for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136629/new/

https://reviews.llvm.org/D136629

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
  llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
  llvm/lib/Target/AMDGPU/VOP2Instructions.td
  llvm/lib/Target/AMDGPU/VOPDInstructions.td
  llvm/test/CodeGen/AMDGPU/vopd-combine.mir
  llvm/test/CodeGen/AMDGPU/vopd-fmac-delay.mir
  llvm/test/CodeGen/AMDGPU/vopd-src2acc-delay.mir
  llvm/test/MC/AMDGPU/gfx11_asm_vopd_errs.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136629.470508.patch
Type: text/x-patch
Size: 18149 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221025/20d8e271/attachment.bin>