[PATCH] D136629: [AMDGPU] Fix delay alu for VOPD with src2acc

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:564
   ComponentLayout(ComponentKind Kind_ = ComponentKind::SINGLE,
-                  unsigned OpXSrcNum_ = 0)
-      : Kind(Kind_), OpXSrcNum(OpXSrcNum_) {
+                  unsigned OpXSrcNum_ = 0, unsigned ParsedOpXSrcNum_ = 0)
+      : Kind(Kind_), OpXSrcNum(OpXSrcNum_), ParsedOpXSrcNum(ParsedOpXSrcNum_) {
----------------
dp wrote:
> foad wrote:
> > Don't need any of these trailing underscores.
> You are right, but I'm not sure if `... : Kind(Kind), ...` is a good and clear style.
It is ubiquitous, and I think it's much better than inventing lots of different conventions (like trailing underscore) to make the argument name different frmo the field name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136629/new/

https://reviews.llvm.org/D136629