[PATCH] D136304: [mlir][MemRefToLLVM] Lower extract_strided_metadata

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp:2123
+    auto sourceMemRefType = source.getType().cast<MemRefType>();
+    size_t rank = sourceMemRefType.getRank();
+    SmallVector<Value> results;
----------------
Nit: getRank returns `int64_t`, let's stick with that to avoid sign-cast warnings in some compilers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136304/new/

https://reviews.llvm.org/D136304