[PATCH] D136611: [Clang][AArch64] Add TargetParser support for defining CPU aliases

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 08:55:58 PDT 2022


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Support/AArch64TargetParser.cpp:213
+
+  // Next, see if it is an alias, and if so, find and return the ArchID of the
+  // CPU it maps to.
----------------
lenary wrote:
> Why not resolve the alias before the loop on line 208? And then you won't need to have two copies of the loop of CPUNames.
Ah yeah, of course, much better and good suggestion. Will fix. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136611/new/

https://reviews.llvm.org/D136611



More information about the llvm-commits mailing list