[PATCH] D136611: [Clang][AArch64] Add TargetParser support for defining CPU aliases

[Sam Elliott via Phabricator via llvm-commits]

lenary added a reviewer: tmatheson.
lenary added a subscriber: tmatheson.
lenary added a comment.

Broadly good! Adding @tmatheson who is also looking at the targetparser code right now.



================
Comment at: llvm/lib/Support/AArch64TargetParser.cpp:213
+
+  // Next, see if it is an alias, and if so, find and return the ArchID of the
+  // CPU it maps to.
----------------
Why not resolve the alias before the loop on line 208? And then you won't need to have two copies of the loop of CPUNames.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136611/new/

https://reviews.llvm.org/D136611