[PATCH] D136583: use riscv vsetvl to tailfolding Co-authored-by: lidawei lidawei.1226 at bytedance.com

Nuno Lopes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 01:27:30 PDT 2022


nlopes added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9851
+              Intrinsic::riscv_vle, {DataTy, MaskTy},
+              {UndefValue::get(DataTy), VecPtr, Mask}, nullptr);
+        else
----------------
Please use PoisonValue whenever possible instead of undef. We are trying to remove undef from LLVM, and thus we would like to avoid any new use unless there's no alternative.
Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136583/new/

https://reviews.llvm.org/D136583



More information about the llvm-commits mailing list