[PATCH] D136464: [AArch64][SVE2] Add the SVE2.1 signed and unsigned 2-way dot instructions

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 01:10:34 PDT 2022


sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:3585-3588
+def SDOT_2WAY_ZZZ_S  : sve2p1_two_way_dot_vv<"sdot", 0b0>;
+def UDOT_2WAY_ZZZ_S  : sve2p1_two_way_dot_vv<"udot", 0b1>;
+def SDOT_2WAY_ZZZI_S : sve2p1_two_way_dot_vvi<"sdot", 0b0>;
+def UDOT_2WAY_ZZZI_S : sve2p1_two_way_dot_vvi<"udot", 0b1>;
----------------
paulwalker-arm wrote:
> For clarity, can you create a follow up patch to ensure all the SVE dot instructions use this format? This presumably means adding `4WAY`.
We should be using VG2 or VG4 for that purpose, that aligns with what we've done for SME2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136464/new/

https://reviews.llvm.org/D136464



More information about the llvm-commits mailing list