[PATCH] D136340: [tests] precommit tests for D136015

Sat Oct 22 05:22:44 PDT 2022

Allen added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/mul_fold.ll:303
+  %addc = add i32 %m10, %m01
+  call void @use32(i32 %addc)
+  %shl = shl i32 %addc, 16
----------------
spatel wrote:
> This extra use means we are still using In0Lo and In1Lo in the multiplies. The test comment above says this and the following tests should not be doing this?
> "the 2nd half have no extra uses to uses the full in0/in1 directly"
so update with "the 2nd half have no extra uses of mul to uses the full in0/in1 directly" to avoid the conflict ?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136340/new/

https://reviews.llvm.org/D136340