[PATCH] D136340: [tests] precommit tests for D136015

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/mul_fold.ll:303
+  %addc = add i32 %m10, %m01
+  call void @use32(i32 %addc)
+  %shl = shl i32 %addc, 16
----------------
This extra use means we are still using In0Lo and In1Lo in the multiplies. The test comment above says this and the following tests should not be doing this?
"the 2nd half have no extra uses to uses the full in0/in1 directly"


================
Comment at: llvm/test/Transforms/InstCombine/mul_fold.ll:762
+
+; Negative test: Should not remote the AND, https://alive2.llvm.org/ce/z/JLmNU5
+define i64 @mul64_low_no_and(i64 %in0, i64 %in1) {
----------------
typo: remove the "add"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136340/new/

https://reviews.llvm.org/D136340