[PATCH] D136394: [Bolt][PseudoProbe] Support new pseudo probe encoding

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.

In D136394#3872849 <https://reviews.llvm.org/D136394#3872849>, @maksfb wrote:

> Is this change going to be tested in the parent diff or otherwise?

Good question. We have internal tests not upstreamed yet. Maybe it's time to upstream them?



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:611-612
+
+  std::unordered_set<uint64_t> GuidFilter;
+  std::unordered_map<uint64_t, uint64_t> FuncStartAddrs;
+  for (const auto *F : BC->getAllBinaryFunctions()) {
----------------
maksfb wrote:
> I left the comment on the parent diff regarding the types.
Thanks, fixed in the parent diff.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:3528
+      uint64_t Addr = F->isEmitted() ? F->getOutputAddress() : F->getAddress();
+      FuncStartAddrs.emplace(Function::getGUID(NameResolver::restore(F->getOneName())), Addr);
+    }
----------------
maksfb wrote:
> nit: this line looks more than 80 chars wide.
oops, thought the linter would help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136394/new/

https://reviews.llvm.org/D136394