[PATCH] D136394: [Bolt][PseudoProbe] Support new pseudo probe encoding

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added a comment.

Is this change going to be tested in the parent diff or otherwise?

A couple of nits: change [Bolt] -> [BOLT] in the Title and use 72-char line width for the Summary.



================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:611-612
+
+  std::unordered_set<uint64_t> GuidFilter;
+  std::unordered_map<uint64_t, uint64_t> FuncStartAddrs;
+  for (const auto *F : BC->getAllBinaryFunctions()) {
----------------
I left the comment on the parent diff regarding the types.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:3527
+    for (const auto *F : BC->getAllBinaryFunctions()) {
+      uint64_t Addr = F->isEmitted() ? F->getOutputAddress() : F->getAddress();
+      FuncStartAddrs.emplace(Function::getGUID(NameResolver::restore(F->getOneName())), Addr);
----------------
nit:


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:3528
+      uint64_t Addr = F->isEmitted() ? F->getOutputAddress() : F->getAddress();
+      FuncStartAddrs.emplace(Function::getGUID(NameResolver::restore(F->getOneName())), Addr);
+    }
----------------
nit: this line looks more than 80 chars wide.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136394/new/

https://reviews.llvm.org/D136394