[PATCH] D136448: [AMDGPU][GISel] Add llvm.amdgcn.icmp selection

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:1084
+    if (Size == 16)
+      return ST.hasTrue16BitInsts() ? TrueS16Opc : S16Opc;
+    if (Size == 32)
----------------
Pierre-vh wrote:
> Note: not sure if "true" or "false" 16 bit insts matter.
> I did both to be safe but I'd be curious to know if it's actually needed.
I think both are needed here. The "true" ones will be used on GFX11 and the "fake"(!) ones on previous subtargets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136448/new/

https://reviews.llvm.org/D136448