[PATCH] D136235: [AMDGPU][GISel] Constrain selected operands in selectG_BUILD_VECTOR
Pierre van Houtryve via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 20 23:50:24 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1809414fe19a: [AMDGPU][GISel] Constrain selected operands in selectG_BUILD_VECTOR (authored by Pierre-vh).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136235/new/
https://reviews.llvm.org/D136235
Files:
llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
Index: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
+++ llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
@@ -686,13 +686,19 @@
// TODO: Can be improved?
if (IsVector) {
Register TmpReg = MRI->createVirtualRegister(&AMDGPU::VGPR_32RegClass);
- BuildMI(*BB, MI, DL, TII.get(AMDGPU::V_AND_B32_e32), TmpReg)
- .addImm(0xFFFF)
- .addReg(Src0);
- BuildMI(*BB, MI, DL, TII.get(AMDGPU::V_LSHL_OR_B32_e64), Dst)
- .addReg(Src1)
- .addImm(16)
- .addReg(TmpReg);
+ auto MIB = BuildMI(*BB, MI, DL, TII.get(AMDGPU::V_AND_B32_e32), TmpReg)
+ .addImm(0xFFFF)
+ .addReg(Src0);
+ if (!constrainSelectedInstRegOperands(*MIB, TII, TRI, RBI))
+ return false;
+
+ MIB = BuildMI(*BB, MI, DL, TII.get(AMDGPU::V_LSHL_OR_B32_e64), Dst)
+ .addReg(Src1)
+ .addImm(16)
+ .addReg(TmpReg);
+ if (!constrainSelectedInstRegOperands(*MIB, TII, TRI, RBI))
+ return false;
+
MI.eraseFromParent();
return true;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136235.469478.patch
Type: text/x-patch
Size: 1176 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221021/62cf7125/attachment.bin>
More information about the llvm-commits
mailing list