[PATCH] D136370: [AMDGPU][MC] Correct definition of aliases

[Joe Nash via Phabricator via llvm-commits]

Joe_Nash added a comment.

Overall looks good. Did you observe any instructions that assembled when they shouldn't? It looks like only differences in error message from the tests.



================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:272
              (inst ps.Pfl.DstRC:$vdst, ps.Pfl.Src0RC32:$src0,
-                   ps.Pfl.Src1RC32:$src1)>,
   PredicateControl {
----------------
Shouldn't it be set on inst.AsmVariantName? I believe by luck they are both Default in all uses.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136370/new/

https://reviews.llvm.org/D136370