[PATCH] D135592: [IR] Add support for memory attribute

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 11:18:24 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/IR/Attributes.cpp:512
+      OS << getModRefStr(OtherMR);
+    }
+
----------------
jdoerfert wrote:
> Here and in the examples, did we go back on the `other` front?
`other` is not available in textual IR, but it is part of the in-memory representation -- we do need *some* way to internally represent everything that does not have a dedicated location kind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135592/new/

https://reviews.llvm.org/D135592



More information about the llvm-commits mailing list