[PATCH] D135592: [IR] Add support for memory attribute

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 09:57:39 PDT 2022


jdoerfert added a comment.

Looks good overall, the `other` uses confused me though.



================
Comment at: llvm/lib/IR/Attributes.cpp:512
+      OS << getModRefStr(OtherMR);
+    }
+
----------------
Here and in the examples, did we go back on the `other` front?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135592/new/

https://reviews.llvm.org/D135592



More information about the llvm-commits mailing list