[PATCH] D135575: [AArch64]SME2 Multi-vector-Multiple Vectors SQDMULH instructions

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Do you have any sqdmulh-diagnostics.s with negative tests for these instructions?



================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:276
 defm SQDMULH_4ZZ : sme2_sqdmulh_add_vector_vg4_single<"sqdmulh", 0b100000>;
+defm SQDMULH_2Z2Z : sme2_sqdmulh_vector_vg2_multi<"sqdmulh">;
+defm SQDMULH_4Z4Z : sme2_sqdmulh_vector_vg4_multi<"sqdmulh">;
----------------
This should be: 2Z2Z2Z
And the suffix below should be: 4Z4Z4Z


================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:278
+defm SQDMULH_4Z4Z : sme2_sqdmulh_vector_vg4_multi<"sqdmulh">;
+
 }
----------------
Out of interest, why are the multiple and single vector variants of sqdmulh not part of this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135575/new/

https://reviews.llvm.org/D135575