[PATCH] D133321: [Assignment Tracking][24/*] Always RemoveRedundantDbgInstrs in instcombine in assignment tracking builds

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

Minor comments, but this looks generally good.



================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/remove-redundant-dbg.ll:1-2
+; RUN: opt -passes=instcombine -S %s -o - -experimental-assignment-tracking \
+; RUN: | FileCheck %s --implicit-check-not="call void @llvm.dbg"
+
----------------
Might be overthinking it, but could there also be a test that we don't remove redundant debug intrinsics when experimental assignment tracking is off? It's not really an error if those intrinsics were removed, but since we're not choosing to enable it for all builds (presumably for performance reasons) that should probably be covered in this test.


================
Comment at: llvm/test/DebugInfo/Generic/assignment-tracking/instcombine/remove-redundant-dbg.ll:20-21
+
+declare !dbg !17 dso_local void @_Z3extv() local_unnamed_addr #1
+declare void @llvm.dbg.assign(metadata, metadata, metadata, metadata, metadata, metadata) #2
+
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133321/new/

https://reviews.llvm.org/D133321