[PATCH] D136195: [AMDGPU] V_LDEXP_F16 encoding fix and doc update.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 01:23:17 PDT 2022


foad accepted this revision.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:845
 let FPDPRounding = 1 in {
-defm V_LDEXP_F16 : VOP2Inst_t16 <"v_ldexp_f16", VOP_F16_F16_I32, AMDGPUldexp>;
+let SubtargetPredicate = NotHasTrue16BitInsts, OtherPredicates = [Has16BitInsts]  in {
+  defm V_LDEXP_F16 : VOP2Inst <"v_ldexp_f16", VOP_F16_F16_I32, AMDGPUldexp>;
----------------
It's a matter of taste, but you don't need the braces if there's only a single def inside the let.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136195/new/

https://reviews.llvm.org/D136195



More information about the llvm-commits mailing list