[PATCH] D135984: Add a "--load-address <addr>" option to llvm-gsymutil.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

You probably should get someone with more knowledge of GSYM/llvm-gsymutil to review the rest of this patch. I've got only one other minor comment.



================
Comment at: llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp:123
+                "displayed in output will be relocated using the new address."),
+                cl::value_desc("l"), cat(GeneralOptions), cl::init(UINT64_MAX));
+
----------------
It's probably fine doing this for the "not specified" value, but I'm not a massive fan of it. Is there a cl::opt method that tells you whether an option has actually been specified or not? (If there isn't, or it's not particularly clean, then this is fine)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135984/new/

https://reviews.llvm.org/D135984