[PATCH] D135984: Add a "--load-address <addr>" option to llvm-gsymutil.

Mon Oct 17 13:57:14 PDT 2022

clayborg marked 4 inline comments as done.
clayborg added a comment.

In D135984#3861527 <https://reviews.llvm.org/D135984#3861527>, @jhenderson wrote:

> I don't know anything about GSYM or llvm-gsymutil really, but this sounds a lot like llvm-symbolizer's `--adjust-vma` option, but rather than being an offset, it sets the address outright. I guess it doesn't really make sense to follow llvm-symbolizer's option name and behaviour instead of this?

It makes more sense to match the "-l" option to atos. Most symbolizing happens on crash logs that either contain load addresses of each shared library and unadjusted PC values, or they contain offsets. I modified the "--load-address" option to be able to have zero set as the value. This allows offsets to be symbolized if "--load-address=0" is set.

> As an aside, I note that llvm-gsymutil doesn't appear to have any CommandGuide documentation in llvm/docs/CommandGuide. Perhaps worth adding at some point...

Definitely! I will submit a follow on patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135984/new/

https://reviews.llvm.org/D135984