[PATCH] D136136: [RISCV] Lower VECTOR_SHUFFLE to VSLIDEDOWN_VL.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 00:07:13 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:2905
+    return SDValue();
+
+  // Mask is also continuous.
----------------
craig.topper wrote:
> I think you need to check that Mask[0] is >= 0.
> I think you need to check that Mask[0] is >= 0.

I guess more precisely, it would need to be > 0 or it would definitely not be a slidedown.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136136/new/

https://reviews.llvm.org/D136136



More information about the llvm-commits mailing list