[PATCH] D136073: [LoongArch] Modify ParserMethod for the simm26_b operand type

wanglei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 19:32:39 PDT 2022


wangleiat added inline comments.


================
Comment at: llvm/test/CodeGen/LoongArch/blockaddress-symbol.ll:7-9
+;; This regression test is intended to prevent the interface
+;; (getOrCreateSymbol()) from being used by the AsmParser to create
+;; blockaddress symbols. Otherwise incorrect symbols will be created:
----------------
xen0n wrote:
> Active voice may be clearer here, also it's not the test that is preventing the regression:
> 
> "This regression test is for ensuring the AsmParser does not use the getOrCreateSymbol interface to create blockaddress symbols."
> Active voice may be clearer here, also it's not the test that is preventing the regression:
> 
> "This regression test is for ensuring the AsmParser does not use the getOrCreateSymbol interface to create blockaddress symbols."

Thank you very much!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136073/new/

https://reviews.llvm.org/D136073



More information about the llvm-commits mailing list