[PATCH] D136073: [LoongArch] Modify ParserMethod for the simm26_b operand type

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 19:26:10 PDT 2022


xen0n accepted this revision.
xen0n added a comment.
This revision is now accepted and ready to land.

LGTM apart from the grammatical nit. Thanks.



================
Comment at: llvm/test/CodeGen/LoongArch/blockaddress-symbol.ll:7-9
+;; This regression test is intended to prevent the interface
+;; (getOrCreateSymbol()) from being used by the AsmParser to create
+;; blockaddress symbols. Otherwise incorrect symbols will be created:
----------------
Active voice may be clearer here, also it's not the test that is preventing the regression:

"This regression test is for ensuring the AsmParser does not use the getOrCreateSymbol interface to create blockaddress symbols."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136073/new/

https://reviews.llvm.org/D136073



More information about the llvm-commits mailing list