[PATCH] D136076: [LoongArch] Report error in AsmParser when rd == rk or rd == rj for AM* instructions

Lu Weining via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 18:42:13 PDT 2022


SixWeining added a comment.

In D136076#3863830 <https://reviews.llvm.org/D136076#3863830>, @xen0n wrote:

> The changes look good but unfortunately the manual (!) is poorly translated in this case. Quoting verbatim, while still comprehensible, is an eyesore that is better fixed.
>
> Here's my take:
>
>   Do this check because the ISA manual says (edited from the original translation):
>   
>   > If the AM* instruction has its rd == rj, an Instruction Non-defined Exception will be triggered when the instruction is executed.
>   >
>   > If the AM* instruction has its rd == rk, the execution result is unpredictable. It is software's responsibility to avoid this situation.
>
> What do you think?

That sounds good. I will take. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136076/new/

https://reviews.llvm.org/D136076



More information about the llvm-commits mailing list