[PATCH] D136076: [LoongArch] Report error in AsmParser when rd == rk or rd == rj for AM* instructions
WÁNG Xuěruì via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 17 18:34:18 PDT 2022
xen0n added a comment.
The changes look good but unfortunately the manual (!) is poorly translated in this case. Quoting verbatim, while still comprehensible, is an eyesore that is better fixed.
Here's my take:
Do this check because the ISA manual says (edited from the original translation):
> If the AM* instruction has its rd == rj, an Instruction Non-defined Exception will be triggered when the instruction is executed.
>
> If the AM* instruction has its rd == rk, the execution result is unpredictable. It is software's responsibility to avoid this situation.
What do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136076/new/
https://reviews.llvm.org/D136076
More information about the llvm-commits
mailing list