[PATCH] D135788: Precommit for SWDEV-353076: Add check directives to existing tests.

Mon Oct 17 03:04:08 PDT 2022

foad added inline comments.

================
Comment at: llvm/test/CodeGen/AMDGPU/fnearbyint.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -check-prefixes=SI %s
+; RUN: llc -march=amdgcn -mcpu=bonaire -verify-machineinstrs < %s | FileCheck -check-prefixes=CI %s
----------------
arsenm wrote:
> Leonc wrote:
> > arsenm wrote:
> > > Can add a common GCN prefix, the SI and CI cases are mostly identical 
> > I got a warning from the update script when I did that. Can it be safely ignored?
> > ```
> > WARNING: Prefix GCN had conflicting output from different RUN lines for all functions in test ../llvm/test/CodeGen/AMDGPU/fnearbyint.ll
> > ```
> Yes
I added a common `SICI` prefix in 0c22f4f5fe44.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135788/new/

https://reviews.llvm.org/D135788