[PATCH] D136032: [X86][2/2] Adding atomic add/sub/or/xor/and lowering into RAO-INT instructions

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 15 20:47:30 PDT 2022


efriedma requested changes to this revision.
efriedma added a comment.
This revision now requires changes to proceed.

I'd rather not do this until we have:

1. Some published document that describes the relationship of these new instructions with the C++ atomic model, including interactions with existing atomic lowering.  (I don't trust that it's correct based on the two sentences in the manual.)
2. Some idea whether this is actually preferable; mfence is expensive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136032/new/

https://reviews.llvm.org/D136032



More information about the llvm-commits mailing list