[PATCH] D135951: [X86] SUPPORT RAO-INT

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:801
+    RXOR,
+    RAND,
+
----------------
very pedantic, but are these likely to get confused with ROR / RAND instructions? Would it be better to use a RAO_ prefix?


================
Comment at: llvm/test/CodeGen/X86/atomic-instructions-32.ll:5
+; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown | FileCheck %s --check-prefixes=X64-NO-RAOINT
+; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown -mattr=+raoint | FileCheck %s --check-prefixes=X64-RAO-INT
+
----------------
Is the -O0 necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135951/new/

https://reviews.llvm.org/D135951