[PATCH] D135515: [SPARC] Don't emit deprecated FP branches when targeting v9

[Koakuma via Phabricator via llvm-commits]

koakuma added a comment.

A question about the CI: It says that the build fails because of clang-format errors, yet when I run it locally it says "clang-format did not modify any files". What do I need to do?



================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:1867
+  if (Subtarget->isV9())
+    setHasMultipleConditionRegisters();
+
----------------
arsenm wrote:
> koakuma wrote:
> > arsenm wrote:
> > > Should add an optimization test for this. There are handful of DAG combines and I think codegenprepare also makes use of this
> > Would rerunning the tests in `2011-01-11-CC.ll` with optimization enabled be enough for this, or do I need to add other tests too?
> I don't know, I would kind of doubt that this changes the output there
Hmm, I still don't know what extra optimizations are done by enabling setHasMultipleConditionRegisters so it's hard to me to make a suitable test case either...

Or, what about this: since currently I'm still unable to get LLVM to emit a code that would use more than one condition register, would it be okay if I remove that part for now and figure out how to deal with setHasMultipleConditionRegisters in a later patch?
For now, preventing it from emitting deprecated opcodes is enough for me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135515/new/

https://reviews.llvm.org/D135515