[PATCH] D135515: [SPARC] Don't emit deprecated FP branches when targeting v9

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 17:45:15 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:1867
+  if (Subtarget->isV9())
+    setHasMultipleConditionRegisters();
+
----------------
koakuma wrote:
> arsenm wrote:
> > Should add an optimization test for this. There are handful of DAG combines and I think codegenprepare also makes use of this
> Would rerunning the tests in `2011-01-11-CC.ll` with optimization enabled be enough for this, or do I need to add other tests too?
I don't know, I would kind of doubt that this changes the output there


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135515/new/

https://reviews.llvm.org/D135515



More information about the llvm-commits mailing list