[PATCH] D135843: [AArch64][NFC][1/4]Refactor 'isBitfieldPositioningOp' so that DAG nodes with different Opcode are handled with separate helper functions

[Mingming Liu via Phabricator via llvm-commits]

mingmingl added a comment.

In D135843#3857868 <https://reviews.llvm.org/D135843#3857868>, @dmgreen wrote:

> You can link patches together with the "Edit Related Revision", allowing them to be stacked together to show they are dependant on one another.
>
> These do seems to end up quite different, even if some of the differences here could be reduced.

Done. Thanks for pointing this out!



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:2510
 
-  KnownBits Known = CurDAG->computeKnownBits(Op);
+  SDNode *OpNode = Op.getNode();
 
----------------
dmgreen wrote:
> If this only has a single use it may be better to inline, so there is only a single variable pointing to Op.
Done by calling the forwarding method of SDValue class as much as possible (here and below)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135843/new/

https://reviews.llvm.org/D135843