[PATCH] D135843: [AArch64][NFC][1/4]Refactor 'isBitfieldPositioningOp' so that DAG nodes with different Opcode are handled with separate helper functions

[Mingming Liu via Phabricator via llvm-commits]

mingmingl updated this revision to Diff 467862.
mingmingl marked 4 inline comments as done.
mingmingl added a comment.

Address comments

1. Call forwarding methods (getOperand, hasOneUse, etc) of class SDValue as much as possible.
2. To minimize displayed diff, reorder functions (declare helpers and define them after 'isBitfieldPositioningOp'); otherwise, newly added helper for AND will be diff'ed against  the original 'isBitfieldPositioningOp'


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135843/new/

https://reviews.llvm.org/D135843

Files:
  llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135843.467862.patch
Type: text/x-patch
Size: 6377 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221014/034d0def/attachment.bin>