[PATCH] D135952: [AArch64]Change printVectorList to print SVE vector range

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 14 01:49:26 PDT 2022


sdesmalen added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-ldN-sret-reg+imm-addr-mode.ll:459
 ; CHECK-NEXT:    addvl x8, x0, #8
-; CHECK-NEXT:    ld4h { z0.h, z1.h, z2.h, z3.h }, p0/z, [x8]
+; CHECK-NEXT:    ld4h { z0.h-z3.h }, p0/z, [x8]
 ; CHECK-NEXT:    ret
----------------
it would be nice to have a space here, e.g. `{ z0.h - z3.h }`.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-ldN-sret-reg+reg-addr-mode.ll:9
 ; CHECK:       // %bb.0:
-; CHECK-NEXT:    ld2b { z0.b, z1.b }, p0/z, [x0, x1]
+; CHECK-NEXT:    ld2b { z0.b-z1.b }, p0/z, [x0, x1]
 ; CHECK-NEXT:    ret
----------------
Hi @CarolineConcatto, the vector-lists with two vectors should keep using the comma separated form, which is the preferred syntax for vector-lists as described in the Architecture Reference Manual.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135952/new/

https://reviews.llvm.org/D135952



More information about the llvm-commits mailing list