[PATCH] D135941: [X86] Support AMX-FP16

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/test/Driver/x86-target-features.c:288
 
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mamx-fp16 %s \
+// RUN: -### -o %t.o 2>&1 | FileCheck -check-prefix=AMX-FP16 %s
----------------
Change to `--target=i386`


================
Comment at: clang/test/Driver/x86-target-features.c:289
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mamx-fp16 %s \
+// RUN: -### -o %t.o 2>&1 | FileCheck -check-prefix=AMX-FP16 %s
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mno-amx-fp16 \
----------------
Don't need here.


================
Comment at: clang/test/Driver/x86-target-features.c:290-291
+// RUN: -### -o %t.o 2>&1 | FileCheck -check-prefix=AMX-FP16 %s
+// RUN: %clang -target i386-unknown-linux-gnu -march=i386 -mno-amx-fp16 \
+// RUN: %s -### -o %t.o 2>&1 | FileCheck -check-prefix=NO-AMX-FP16 %s
+// AMX-FP16: "-target-feature" "+amx-fp16"
----------------
ditto.


================
Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:5121
+// AMX_FP16 - Intel FP16 AMX extensions
+//AMX-FP16
+  def int_x86_tdpfp16ps : ClangBuiltin<"__builtin_ia32_tdpfp16ps">,
----------------
Remove


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135941/new/

https://reviews.llvm.org/D135941