[PATCH] D135941: [X86] Support AMX-FP16

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Basic/Targets/X86.cpp:781
+    Builder.defineMacro("__AMXFP16__");
+  Builder.defineMacro("__AMXFP16_SUPPORTED__");
   if (HasAVXVNNI)
----------------
This can be removed.


================
Comment at: clang/lib/Headers/immintrin.h:511
 #endif
+#if defined(__AMXFP16_SUPPORTED__)
+#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||      \
----------------
Remove


================
Comment at: clang/lib/Headers/immintrin.h:513
+#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) ||      \
+    defined(__AMXFP16__) || defined(__M_INTRINSIC_PROMOTE__)
+#include <amxfp16intrin.h>
----------------
Remove


================
Comment at: clang/lib/Sema/SemaChecking.cpp:5030
     return CheckX86BuiltinTileRangeAndDuplicate(TheCall, {0, 1, 2});
+  case X86::BI__builtin_ia32_tdpfp16ps:
+    return CheckX86BuiltinTileRangeAndDuplicate(TheCall, {0, 1, 2});
----------------
This can be merged together?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135941/new/

https://reviews.llvm.org/D135941