[PATCH] D135674: [NVPTX] Fix pointer argument declaration for --nvptx-short-ptr
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 13 10:25:05 PDT 2022
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
================
Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp:1585
+ } else if (PTy) {
+ assert(PTySizeInBits && "Invalid pointer size");
+ sz = PTySizeInBits;
----------------
The assertion should probably be moved to where we set `PTySizeInBits`, so it covers `if(isKernelFunc)` case, too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135674/new/
https://reviews.llvm.org/D135674
More information about the llvm-commits
mailing list