[PATCH] D135674: [NVPTX] Fix pointer argument declaration for --nvptx-short-ptr

Andrew Savonichev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 13 02:48:30 PDT 2022


asavonic added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp:1536
+            TLI->getPointerTy(DL, PTy->getAddressSpace()).getSizeInBits();
+      }
+
----------------
tra wrote:
> Should there be an `else PTySizeInBits =    TLI->getPointerTy(DL).getSizeInBits()` ?
> 
We only use PTySizeInBits when PTy is set. I've now changed the condition below to make it clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135674/new/

https://reviews.llvm.org/D135674



More information about the llvm-commits mailing list