[PATCH] D135264: [MachineCombiner][RISCV] Enable MachineCombiner for RISCV

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:1155
+
+  for (auto NewMI : InsInstrs) {
+    assert(static_cast<unsigned>(RISCV::getNamedOperandIdx(
----------------
`auto *NewMi`


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:1220
+    Patterns.push_back(MachineCombinerPattern::REASSOC_XA_BY);
+    Added |= true;
+  }
----------------
Use `Added = true`. No need for `|`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135264/new/

https://reviews.llvm.org/D135264