[PATCH] D135597: [LangRef] Add memory attribute

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D135597#3852809 <https://reviews.llvm.org/D135597#3852809>, @jdoerfert wrote:

> Do we need two spelling "`memory()` or `memory(none)`:"?

Nope. I'll drop the `memory()` spelling.



================
Comment at: llvm/docs/LangRef.rst:1772
+    ``memory`` attribute with the union of the function ``memory`` attribute
+    and any effects implied by operand bundles.
 ``minsize``
----------------
jdoerfert wrote:
> intersection ... union ... does at best read confusing. Either we need to "union" both sides first or we just don't talk about that and simply write:
> ```
>  The memory effects of a call is the intersection of the call-site
>     ``memory`` attribute with the function ``memory`` attribute and any effects implied by operand bundles.
> ```
What I mainly wanted to highly here is that the result is `CallSiteEffects & (FuncEffects | BundleEffects)`, rather than other combinations, such as `(CallSiteEffects & FuncEffects) | BundleEffects`.

Maybe I should just write that out in code form, rather than make people try to parse English?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135597/new/

https://reviews.llvm.org/D135597